Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Monokai themes #249

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Fix Monokai themes #249

merged 1 commit into from
Aug 31, 2021

Conversation

MarcMush
Copy link
Contributor

This is closer to Monokai in Sublime Text or VS Code, also more legible

(before => after)
image

for reference, in VS Code:
image

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #249 (afddc98) into master (091bea8) will increase coverage by 0.49%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   18.78%   19.28%   +0.49%     
==========================================
  Files          12       12              
  Lines         841      866      +25     
==========================================
+ Hits          158      167       +9     
- Misses        683      699      +16     
Impacted Files Coverage Δ
src/passes/colorschemes.jl 0.00% <0.00%> (ø)
src/passes/SyntaxHighlighter.jl 43.58% <0.00%> (-0.42%) ⬇️
src/repl.jl 0.00% <0.00%> (ø)
src/BracketInserter.jl 0.00% <0.00%> (ø)
src/MarkdownHighlighter.jl 0.00% <0.00%> (ø)
src/passes/RainbowBrackets.jl 100.00% <0.00%> (ø)
src/repl_pass.jl 58.06% <0.00%> (+0.59%) ⬆️
src/passes/BracketHighlighter.jl 88.37% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091bea8...afddc98. Read the comment docs.

@MarcMush
Copy link
Contributor Author

also, maybe "Monokai24bit" could be the default theme on windows for julia > 1.6, since it's now supported

@KristofferC
Copy link
Owner

👍

@KristofferC KristofferC merged commit 786e947 into KristofferC:master Aug 31, 2021
@MarcMush MarcMush deleted the fix-monokai branch August 31, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants