default to 256 color with julia1.5.3 and later on windows #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 19.28% 19.47% +0.18%
==========================================
Files 12 12
Lines 866 868 +2
==========================================
+ Hits 167 169 +2
Misses 699 699
Continue to review full report at Codecov.
|
|
@KristofferC is this something we want ? (I would say yes) |
|
Sorry for the slow response here. Have you tried this with CMD.exe on Windows? Does it work well? I thought that only supported 16 colors. But maybe we shouldn't optimize for the worse terminal... |
|
yes! |
|
also, that's why I added the new variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a more thorough check would be better but I guess this would be the job of Crayons.jl (ref KristofferC/Crayons.jl#15)
based on my testing, support is here starting from julia 1.5.3, even though it only appears in the 1.6 NEWS (PR is not linked, I don't know where exactly it was fixed)