Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to JuliaSyntax.jl over Tokenize.jl #277

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

KristofferC
Copy link
Owner

JuliaSyntax.jl is the future of Julia parsing in Julia so it makes sense to start using that over Tokenize.jl that will likely be deprecated.

@KristofferC
Copy link
Owner Author

The latency is unfortunately quite a bit worse here. JuliaLang/JuliaSyntax.jl#213 fixes it though.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Patch coverage: 80.43% and project coverage change: +33.22 🎉

Comparison is base (aa1d7e2) 19.44% compared to head (c0011c4) 52.67%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #277       +/-   ##
===========================================
+ Coverage   19.44%   52.67%   +33.22%     
===========================================
  Files          12       13        +1     
  Lines         869      953       +84     
===========================================
+ Hits          169      502      +333     
+ Misses        700      451      -249     
Impacted Files Coverage Δ
src/MarkdownHighlighter.jl 0.00% <0.00%> (ø)
src/OhMyREPL.jl 17.07% <ø> (+2.43%) ⬆️
src/repl.jl 13.06% <0.00%> (+13.06%) ⬆️
src/repl_pass.jl 61.05% <83.33%> (+2.10%) ⬆️
src/passes/SyntaxHighlighter.jl 69.23% <92.85%> (+25.64%) ⬆️
src/passes/BracketHighlighter.jl 88.63% <100.00%> (+0.26%) ⬆️
src/passes/RainbowBrackets.jl 100.00% <100.00%> (ø)
src/prompt.jl 0.00% <0.00%> (ø)
src/output_prompt_overwrite.jl 0.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KristofferC KristofferC force-pushed the kc/juliasyntax branch 2 times, most recently from c0011c4 to 20c0e62 Compare March 15, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants