-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove expensive !stabOperatorPrefix #943
Merged
Merged
Commits on Dec 4, 2017
-
Look at the execution test variance for Fn1 vs Fn8.
Configuration menu - View commit details
-
Copy full SHA for 1c8a64e - Browse repository at this point
Copy the full SHA 1c8a64eView commit details -
Only allow no argument stab operations by themselves
Move `stabInfixOperator` out of `stabOperationPrefix` because no argument patterns can only appear first and once in a given stab. This cuts the Fn8 time from 26 seconds to 13 seconds.
Configuration menu - View commit details
-
Copy full SHA for 50a2550 - Browse repository at this point
Copy the full SHA 50a2550View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33e9ec8 - Browse repository at this point
Copy the full SHA 33e9ec8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6e8b92 - Browse repository at this point
Copy the full SHA e6e8b92View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbd4f80 - Browse repository at this point
Copy the full SHA cbd4f80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90dd8b0 - Browse repository at this point
Copy the full SHA 90dd8b0View commit details -
EOL after block identifiers count as WHITE_SPACE
* after * catch * else * rescue
Configuration menu - View commit details
-
Copy full SHA for 72ad38a - Browse repository at this point
Copy the full SHA 72ad38aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ce2159 - Browse repository at this point
Copy the full SHA 3ce2159View commit details
Commits on Dec 5, 2017
-
Configuration menu - View commit details
-
Copy full SHA for cf6d216 - Browse repository at this point
Copy the full SHA cf6d216View commit details -
EOL before
end
counts as WHITE_SPACEAdditionally, only last EOL before counts as EOL. All others are WHITE_SPACE.
Configuration menu - View commit details
-
Copy full SHA for c6c89ab - Browse repository at this point
Copy the full SHA c6c89abView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6c2cdf - Browse repository at this point
Copy the full SHA d6c2cdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 572a18f - Browse repository at this point
Copy the full SHA 572a18fView commit details -
Remove expensive !stabOperatorPrefix
Remove `!stabOperationPrefix` before `expression`, since `stabOperationPrefix` itself starts with `expression` and instead put a negative look-ahead, `!(infixComma | stabInfixOperator)` after `expression`. This now works when it previously didn't because `COMMA` was added to `expressionRecoverUntil`, which means both `COMMA` and `STAB_OPERATOR` are now in both not eaten by `expression`'s error recovery. This drops Fn1 through Fn8 to ~176ms instead of the previous time of the last optimization of 13 seconds for Fn8. It started at 26 seconds and now it appears that the time no longer grows with the number of Fn.
Configuration menu - View commit details
-
Copy full SHA for f5b45f7 - Browse repository at this point
Copy the full SHA f5b45f7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.