Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metrics auth proxy #24

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mikenairn
Copy link
Member

Removes the metrics auth proxy container from the default deployment to make it consistent with all other kuadrant components.

Verifiction

Terminal 1:

make local-setup local-deploy
kubectl -n dns-operator-system port-forward service/dns-operator-controller-manager-metrics-service 28080:8080

Terminal 2:

curl http://127.0.0.1:28080/metrics                               
# HELP certwatcher_read_certificate_errors_total Total number of certificate read errors                               
# TYPE certwatcher_read_certificate_errors_total counter                                                               
certwatcher_read_certificate_errors_total 0                                                                            
# HELP certwatcher_read_certificate_total Total number of certificate reads                                            
# TYPE certwatcher_read_certificate_total counter                                                                      
certwatcher_read_certificate_total 0                                                                                                                                                                                                          
# HELP controller_runtime_active_workers Number of currently used workers per controller                               
# TYPE controller_runtime_active_workers gauge                                                                         
controller_runtime_active_workers{controller="dnshealthcheckprobe"} 0                                                  
controller_runtime_active_workers{controller="dnsrecord"} 0                                                            
controller_runtime_active_workers{controller="managedzone"} 0 
...

Removes the metrics auth proxy container form the default deployment to
make it consistent with all other kuadrant components.
@mikenairn
Copy link
Member Author

@eguzki Would you mind casting your eye over this if you have a minute? I think you removed the proxy from most of the other operators, at least limitador and kuadrant operators.

Copy link
Contributor

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was comparing changes with Kuadrant/kuadrant-operator#33 and LGTM

Verification steps pass 🆗

@mikenairn mikenairn merged commit a8c9daa into Kuadrant:main Feb 16, 2024
8 checks passed
@mikenairn mikenairn deleted the remove_metrics_auth_proxy branch February 16, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants