Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: improve node menu performance #3452

Open
wants to merge 1 commit into
base: 7.x
Choose a base branch
from

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Oct 13, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Fixed tickets

WIP PR to improve the performance of the NodeMenu class. This is early WIP and not fully tested. Feel free to test this and/or use the branch as a base and finish the improvements!

@@ -306,37 +219,22 @@ public function getActiveForDepth($depth)
*/
public function getChildren(Node $node, $includeHiddenFromNav = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants