Skip to content

Commit

Permalink
update opj status in releaseTargets (#280)
Browse files Browse the repository at this point in the history
  • Loading branch information
ColdsteelRail authored Sep 19, 2024
1 parent e43c4c0 commit 906dbe2
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions pkg/controllers/operationjob/operationjob_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ func (r *ReconcileOperationJob) releaseTargets(ctx context.Context, operationJob
return err
}

_, err = controllerutils.SlowStartBatch(len(candidates), controllerutils.SlowStartInitialBatchSize, false, func(i int, _ error) error {
_, releaseErr := controllerutils.SlowStartBatch(len(candidates), controllerutils.SlowStartInitialBatchSize, false, func(i int, _ error) error {
candidate := candidates[i]
err := actionHandler.ReleaseTarget(ctx, candidate, operationJob)
// mark candidate as failed if not finished
Expand All @@ -249,7 +249,9 @@ func (r *ReconcileOperationJob) releaseTargets(ctx context.Context, operationJob
}
return err
})
return err
operationJob.Status = r.calculateStatus(operationJob, candidates)
updateErr := r.updateStatus(ctx, operationJob)
return controllerutils.AggregateErrors([]error{releaseErr, updateErr})
}

func (r *ReconcileOperationJob) cleanCandidateOpsLifecycle(ctx context.Context, forced bool, candidate *OpsCandidate, operationJob *appsv1alpha1.OperationJob) error {
Expand Down

0 comments on commit 906dbe2

Please sign in to comment.