Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #135: update all pod if partition > replicas #144

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

ColdsteelRail
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references ("fix #135 "):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af0a806) 63.54% compared to head (74d54d3) 63.56%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   63.54%   63.56%   +0.02%     
==========================================
  Files          72       72              
  Lines        4704     4704              
==========================================
+ Hits         2989     2990       +1     
+ Misses       1430     1429       -1     
  Partials      285      285              
Flag Coverage Δ
unittests 63.56% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit 5d71851 into KusionStack:main Jan 6, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
@ColdsteelRail ColdsteelRail deleted the fix-out-of-range-partition branch July 8, 2024 06:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: index out range when collaset spec.replicas < partition
2 participants