Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin setup-envtest #169

Merged

Conversation

ColdsteelRail
Copy link
Member

@ColdsteelRail ColdsteelRail commented Mar 25, 2024

Test fails because of recent bug kubernetes-sigs/controller-runtime#2720

In order to unblock the CI, we are pinning
sigs.k8s.io/controller-runtime/tools/setup-envtest at previous working
commit[2]

[1]. kubernetes-sigs/controller-runtime#2720
[2]. kubernetes-sigs/controller-runtime@c7e1dc9

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.97%. Comparing base (abd79c5) to head (fa3d82b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   64.12%   63.97%   -0.15%     
==========================================
  Files          73       73              
  Lines        4708     4708              
==========================================
- Hits         3019     3012       -7     
- Misses       1414     1420       +6     
- Partials      275      276       +1     
Flag Coverage Δ
unittests 63.97% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Eikykun Eikykun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Eikykun Eikykun merged commit 72fb78d into KusionStack:main Mar 25, 2024
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
@Eikykun Eikykun changed the title fix: stable setup-envtest version fix: pin setup-envtest Mar 25, 2024
@ColdsteelRail ColdsteelRail deleted the use-stable-setup-envtest-version branch July 8, 2024 06:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants