Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale and Update Parall with revert partition #219

Merged

Conversation

ColdsteelRail
Copy link
Member

@ColdsteelRail ColdsteelRail commented Jun 9, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ColdsteelRail ColdsteelRail changed the title Scale update parall revert partition Scale and Update Parall with revert partition Jun 11, 2024
@ColdsteelRail ColdsteelRail force-pushed the scale-update-parall-revert-partition branch from a29b0d3 to a59eebf Compare June 11, 2024 10:16
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.26%. Comparing base (fd4de2e) to head (9bbafcc).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/controllers/utils/error.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   66.28%   66.26%   -0.03%     
==========================================
  Files          74       75       +1     
  Lines        5173     5190      +17     
==========================================
+ Hits         3429     3439      +10     
- Misses       1423     1430       +7     
  Partials      321      321              
Flag Coverage Δ
unittests 66.26% <91.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColdsteelRail ColdsteelRail force-pushed the scale-update-parall-revert-partition branch from d574db4 to 9f6b1b2 Compare June 12, 2024 01:32
@ColdsteelRail ColdsteelRail force-pushed the scale-update-parall-revert-partition branch from 32320a5 to e512fd8 Compare June 12, 2024 01:52
@ColdsteelRail ColdsteelRail force-pushed the scale-update-parall-revert-partition branch from 760501f to 4074381 Compare June 12, 2024 04:30
@ColdsteelRail ColdsteelRail force-pushed the scale-update-parall-revert-partition branch from b6bcc18 to 75d2e66 Compare June 13, 2024 06:06
@ColdsteelRail ColdsteelRail force-pushed the scale-update-parall-revert-partition branch from ee66fdf to a9862ba Compare June 13, 2024 07:28
@ColdsteelRail ColdsteelRail force-pushed the scale-update-parall-revert-partition branch 2 times, most recently from bc1b723 to 4f85658 Compare July 1, 2024 03:38
@ColdsteelRail ColdsteelRail force-pushed the scale-update-parall-revert-partition branch from 4f85658 to 3ee9da2 Compare July 1, 2024 06:05
@ColdsteelRail ColdsteelRail force-pushed the scale-update-parall-revert-partition branch 2 times, most recently from d0f8d56 to 7ff34cc Compare July 3, 2024 02:06
@ColdsteelRail ColdsteelRail force-pushed the scale-update-parall-revert-partition branch from 7ff34cc to 9bbafcc Compare July 3, 2024 02:08
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit 2850868 into KusionStack:main Jul 5, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
@ColdsteelRail ColdsteelRail deleted the scale-update-parall-revert-partition branch July 8, 2024 06:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力
2 participants