Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct json tag last_transition_time to lastTransitionTime #25

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

zoumo
Copy link
Collaborator

@zoumo zoumo commented Aug 15, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@zoumo
Copy link
Collaborator Author

zoumo commented Aug 15, 2023

I have read the CLA Document and I hereby sign the CLA

@zoumo zoumo requested a review from Eikykun August 15, 2023 07:52
Copy link
Collaborator

@Eikykun Eikykun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikykun Eikykun merged commit e840810 into main Aug 15, 2023
5 checks passed
@Eikykun Eikykun deleted the api-json-tag branch August 15, 2023 08:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
@Eikykun Eikykun added kind/bug Something isn't working lgtm labels Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants