Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operate targets in batch #279

Merged
merged 16 commits into from
Oct 8, 2024
Merged

operate targets in batch #279

merged 16 commits into from
Oct 8, 2024

Conversation

ColdsteelRail
Copy link
Member

@ColdsteelRail ColdsteelRail commented Sep 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 16 lines in your changes missing coverage. Please review.

Project coverage is 66.15%. Comparing base (8baf05f) to head (bc2dbd9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...g/controllers/operationjob/operationjob_manager.go 68.62% 12 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   65.90%   66.15%   +0.25%     
==========================================
  Files          78       78              
  Lines        5611     5647      +36     
==========================================
+ Hits         3698     3736      +38     
+ Misses       1553     1552       -1     
+ Partials      360      359       -1     
Flag Coverage Δ
unittests 66.15% <71.42%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColdsteelRail ColdsteelRail force-pushed the operationjob-in-batch branch 3 times, most recently from e1e2a64 to a1de101 Compare September 26, 2024 02:52
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit 148e0af into main Oct 8, 2024
10 checks passed
@wu8685 wu8685 deleted the operationjob-in-batch branch October 8, 2024 07:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力
2 participants