Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor activeDeadlineSeconds to target-level #284

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

ColdsteelRail
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.42%. Comparing base (4fa8b0e) to head (33acb9e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ontrollers/operationjob/operationjob_controller.go 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   65.99%   66.42%   +0.42%     
==========================================
  Files          78       78              
  Lines        5647     5665      +18     
==========================================
+ Hits         3727     3763      +36     
+ Misses       1559     1546      -13     
+ Partials      361      356       -5     
Flag Coverage Δ
unittests 66.42% <94.23%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColdsteelRail ColdsteelRail force-pushed the refactor-active-deadline-seconds branch 3 times, most recently from f02474b to 6d166f2 Compare September 27, 2024 11:03
@ColdsteelRail ColdsteelRail force-pushed the refactor-active-deadline-seconds branch from 6d166f2 to 18d0e7b Compare October 8, 2024 11:15
@ColdsteelRail ColdsteelRail changed the title Refactor active deadline seconds refactor activeDeadlineSeconds from job-level to target-level Oct 10, 2024
@ColdsteelRail ColdsteelRail changed the title refactor activeDeadlineSeconds from job-level to target-level refactor activeDeadlineSeconds to target-level Oct 10, 2024
@ColdsteelRail
Copy link
Member Author

refactor activeDeadlineSeconds from job-level to target-level configuration

the TTL seconds is still job-level configuration

Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit b24b8b9 into main Oct 11, 2024
10 checks passed
@wu8685 wu8685 deleted the refactor-active-deadline-seconds branch October 11, 2024 04:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力
3 participants