-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix, podopslifecycle webhook #60
Conversation
2d9a312
to
019da86
Compare
019da86
to
886a51f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
@@ -27,6 +27,7 @@ import ( | |||
|
|||
"kusionstack.io/kafed/apis/apps/v1alpha1" | |||
"kusionstack.io/kafed/pkg/controllers/podopslifecycle" | |||
controllerutils "kusionstack.io/kafed/pkg/controllers/utils" | |||
"kusionstack.io/kafed/pkg/utils" | |||
) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Becuase we are not able to change labels when client.Status().Update()
, how about to filter out the request updating Pod status
to skip following process as a shortcut?
b204e5f
to
bb1040a
Compare
bb1040a
to
fd34779
Compare
db21af8
to
9c9a440
Compare
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.