Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(CollaSet): update currentRevision to updatedRevision afte… #83

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

wu8685
Copy link
Collaborator

@wu8685 wu8685 commented Sep 1, 2023

…r all Pods is updated and got ready

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

ref #82

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

enhancement(CollaSet): update currentRevision to updatedRevision after all Pods is updated and got ready

@wu8685 wu8685 self-assigned this Sep 1, 2023
@wu8685 wu8685 added kind/enhancement New feature or request operating labels Sep 1, 2023
Copy link
Collaborator

@WeichengWang1 WeichengWang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WeichengWang1 WeichengWang1 merged commit 6b8f76a into main Sep 1, 2023
5 checks passed
@WeichengWang1 WeichengWang1 deleted the adjust-updated-revision-standard branch September 1, 2023 08:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request operating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants