Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatible if PodAvailableConditionsAnnotation already exist dur… #25

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

WeichengWang1
Copy link
Collaborator

@WeichengWang1 WeichengWang1 commented Jan 3, 2024

…ing creation

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

fix #24

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f603dea) 66.07% compared to head (dfd9fcb) 64.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   66.07%   64.95%   -1.12%     
==========================================
  Files           4        4              
  Lines         896      896              
==========================================
- Hits          592      582      -10     
- Misses        232      239       +7     
- Partials       72       75       +3     
Flag Coverage Δ
unittests 64.95% <ø> (-1.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WeichengWang1 WeichengWang1 self-assigned this Jan 3, 2024
Copy link

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit ed2d258 into main Jan 3, 2024
5 checks passed
@wu8685 wu8685 deleted the availableConditionFix branch January 3, 2024 09:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants