Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: api version updated to 2024-04 #307

Merged
merged 1 commit into from
May 16, 2024
Merged

misc: api version updated to 2024-04 #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/resources/config/shopify-app.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@
|
*/

'api_version' => env('SHOPIFY_API_VERSION', '2024-01'),
'api_version' => env('SHOPIFY_API_VERSION', '2024-04'),

/*
|--------------------------------------------------------------------------
Expand Down Expand Up @@ -396,8 +396,7 @@
'address' => env('SHOPIFY_WEBHOOK_3_ADDRESS', 'https://some-app.com/webhook/orders-create'),
'class' => \App\Shopify\Actions\ExampleAppJob::class
],
*/
],
*/],

/*
|--------------------------------------------------------------------------
Expand All @@ -416,8 +415,7 @@
'display_scope' => env('SHOPIFY_SCRIPTTAG_1_DISPLAY_SCOPE', 'online_store')
],
...
*/
],
*/],

/*
|--------------------------------------------------------------------------
Expand All @@ -441,8 +439,7 @@
'job' => env('AFTER_AUTHENTICATE_JOB'), // example: \App\Jobs\AfterAuthorizeJob::class
'inline' => env('AFTER_AUTHENTICATE_JOB_INLINE', false) // False = dispatch job for later, true = dispatch immediately
],
*/
],
*/],

/*
|--------------------------------------------------------------------------
Expand Down Expand Up @@ -551,7 +548,7 @@
* Cache duration
*/
'cache_duration' => 12,
/*
/*
* At which levels of theme support the use of "theme app extension" is not available
* and script tags will be installed.
* Available levels: FULL, PARTIAL, UNSUPPORTED.
Expand Down
2 changes: 1 addition & 1 deletion tests/Services/ApiHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function testMake(): void
$this->assertInstanceOf(BasicShopifyAPI::class, $api);
$this->assertSame(Util::getShopifyConfig('api_secret'), $this->app['config']->get('shopify-app.api_secret'));
$this->assertSame(Util::getShopifyConfig('api_key'), $this->app['config']->get('shopify-app.api_key'));
$this->assertSame($this->app['config']->get('shopify-app.api_version'), '2024-01');
$this->assertSame($this->app['config']->get('shopify-app.api_version'), '2024-04');
}

public function testSetAndGetApi(): void
Expand Down
Loading