Include community texts in the artifact produced by the CI workflow #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include community text files in the artifact
rsribeiro
reviewed
Aug 6, 2022
SOURCES/Assets/Text/README.md
Outdated
|
|
||
| Edit: To support the artifact produced by the CI workflow, ONE_GAME_DIRECTORY currently has no effect on the default location of these texts. Since this may change in the future, by default, if the *ONE_GAME_DIRECTORY* flag was set to *true* in the code, the texts would have to be copied to the exact same location as *'LBA0.exe'*, instead of *'..\Assets\Text'*. |
There was a problem hiding this comment.
We could add a step to copy LBA0.exe and all the translation CSVs to the same folder before creating the zip artifact, to retain the behaviour of the ONE_GAME_DIRECTORY flag
There was a problem hiding this comment.
Yeah... Turns out I overlooked the fact that these are Powershell commands so it's fairly simple to put them in the same folder. It should be fixed now and no changes required to the behaviour of ONE_GAME_DIRECTORY any longer
This reverts commit ea3c97b.
rsribeiro
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.