Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default-energy-primary.csv from all vehicleTypes.csv files #1988

Closed
colinsheppard opened this issue Jul 17, 2019 · 1 comment · Fixed by #1989
Closed

Remove default-energy-primary.csv from all vehicleTypes.csv files #1988

colinsheppard opened this issue Jul 17, 2019 · 1 comment · Fixed by #1989
Assignees

Comments

@colinsheppard
Copy link
Contributor

Across all input data, including in all production branches, please find all instances of a vehicleTypes.csv file (and the variations on that same file) and remove any reference to

"default-energy-primary.csv"

or

"default-energy-secondary.csv"

in these files. We don't need to specify a file path for the columns "primaryVehicleEnergyFile" and "secondaryVehicleEnergyFile" so these can be left blank instead of referring to some default energy file.

If there is a value that refers to an actual file (e.g. "/AllAboutMe_longTerm_highTech/conv-car-gas.csv.gz") then definitely leave that

@JustinPihony
Copy link
Collaborator

The biggest difference here is that if there is no file specified then it will use the fallback calculation, which is a static number. Whereas the default allows for a more dynamic calculation based on grades, lanes, speed, and such. Granted the default is more geared towards a specific zone, so maybe that's why we want to go with the static default versus dynamic default. Alternatively, we could have a single location where we specify the default file locations. But I guess that would just about negate the static fallback entirely. More food for thought than anything else.

colinsheppard added a commit that referenced this issue Aug 14, 2019
…efault-energy-PrimarySecondry-4ci

remove default energy primary and secondary file path from vehicleTyp…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants