Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 15% and 30% line text #1750

Merged
merged 4 commits into from
Jun 11, 2019
Merged

fix 15% and 30% line text #1750

merged 4 commits into from
Jun 11, 2019

Conversation

rajnikantsh
Copy link
Collaborator

@rajnikantsh rajnikantsh commented Apr 24, 2019 •
edited by JustinPihony
Loading

Fixes #1714

This change is Reviewable

@ghost ghost assigned rajnikantsh Apr 24, 2019
@ghost ghost added the Review label Apr 24, 2019
@ghost ghost assigned JustinPihony Apr 29, 2019
JustinPihony
JustinPihony approved these changes Apr 29, 2019
View reviewed changes
Copy link
Collaborator

@JustinPihony JustinPihony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but @wrashid should probably verify this is what he meant in 1714

@wrashid wrashid merged commit 24a21a0 into develop Jun 11, 2019
@JustinPihony JustinPihony deleted the rajnikantsh/#1714-fix-line_text-4ci branch June 30, 2019 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinPihony JustinPihony JustinPihony approved these changes

Assignees

@JustinPihony JustinPihony

@rajnikantsh rajnikantsh

Labels
Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

observed vs. simulated times: 15% and 30% lines need to be corrected
3 participants
@rajnikantsh @JustinPihony @wrashid