jhrf/#1127 ev charging filter results #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneshiry
approved these changes
Jul 22, 2019
There was a problem hiding this comment.
Looks fine to me - unsure about the lines where I made a comment but it also looks fine in combination with the code below - just to be sure maybe @colinsheppard can take a short look at it that the introduction of "charge" and the change from "work" to "charge" doesn't break anything in RideHailing
| @@ -534,7 +534,7 @@ class RideHailAgent( | |||
| "installedCapacity" -> UtilityFunctionOperation("multiplier", -beta3) | |||
| ) | |||
| val mnl = new MultinomialLogit[ParkingZoneSearch.ParkingAlternative, String](Map.empty, commonUtilityParams) | |||
| val inquiry = ParkingInquiry(destinationUtm, "work", 0.0, mnl, 0.0) | |||
| val inquiry = ParkingInquiry(destinationUtm, "charge", 0.0, mnl, 0.0, Option(vehicle)) | |||
There was a problem hiding this comment.
I have no idea if this is correct or not - maybe @colinsheppard knows if this is fine?
There was a problem hiding this comment.
sorry, can't tell by glancing at it
| val destinationUtm = rideHailAgentLocation.currentLocationUTM.loc | ||
| val inquiry = ParkingInquiry(destinationUtm, "work") | ||
| val inquiry = ParkingInquiry(destinationUtm, "charge", Option(beamVehicle)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter the parking stalls returned from parking search based on context to allow or not allow vehicles to park in stalls with chargers. Intended to keep chargers from filling up with non-EVs and to ensure that EVs find any available chargers when they need to charge.
This change is