minSearchRadius config parameter added #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parking search's min search radius has been fixed since the dawn of time and Thor cast his first code smell upon the land.
so, when we randomly sample our parking zones based on utility, it would make sense to only be picking from maybe less than 30 i'm guessing alternatives. unfortunately, we have had a 1000-meter min search radius. here's a quick comparison between 1000 meter min search radius and 250 meter:
this PR does the following:
beam.agentsim.agents.parking.minSearchRadiusCloses #2124.
This change is