Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inm/fix not updating in real time config values 2 #2151

Merged
merged 27 commits into from
Oct 30, 2019
Merged

Inm/fix not updating in real time config values 2 #2151

merged 27 commits into from
Oct 30, 2019

Conversation

nikolayilyin
Copy link
Collaborator

@nikolayilyin nikolayilyin commented Sep 4, 2019 •
edited by colinsheppard
Loading

output files are writing according to run time changes of *interval config values

This change is Reviewable

nikolayilyin and others added 16 commits September 4, 2019 22:32
@nikolayilyin
added BeamServices as field into BeamSkimmer and TravelTimeObserved i…
83dc44a 
…n order to get config updates
@nikolayilyin
FastHouseholdCAVSchedulingSpec format fix
0a508c7
@nikolayilyin
writeEventsInterval getting from beamServices to get updates in runtime
e3f9fa5
@rajnikantsh @nikolayilyin
add listener for last iteration
3b51704
@nikolayilyin
fix for writePlansInterval config value
8d33f5f
@nikolayilyin
fix of division by zero
c6ff2e6
@nikolayilyin
added BeamServices as field into BeamSkimmer and TravelTimeObserved i…
1513fe7 
…n order to get config updates
@nikolayilyin
FastHouseholdCAVSchedulingSpec format fix
dc2dd1e
@nikolayilyin
writeEventsInterval getting from beamServices to get updates in runtime
f527a46
@nikolayilyin
fix for writePlansInterval config value
db895fb
@nikolayilyin
cherry-pick fix
b6460bd
@nikolayilyin
fix of division by zero
4423bd6
@nikolayilyin
fix for tests after introducing of runtime updates of lastIteration…
8c54b49 
… config value
@nikolayilyin
added control over linkstats.txt.gz file writing
a9d6f9b
@nikolayilyin
default values for linkStats module config
074b9d2
@nikolayilyin
fmt + possible fix for failing test
04b7a9b
@nikolayilyin
Copy link
Collaborator Author

Test!

1 similar comment
@nikolayilyin
Copy link
Collaborator Author

Test!

@nikolayilyin
Copy link
Collaborator Author

Test!

1 similar comment
@nikolayilyin
Copy link
Collaborator Author

Test!

@nikolayilyin
Copy link
Collaborator Author

Test!

1 similar comment
@nikolayilyin
Copy link
Collaborator Author

Test!

@nikolayilyin
Copy link
Collaborator Author

Test!

1 similar comment
@nikolayilyin
Copy link
Collaborator Author

Test!

@nikolayilyin
Copy link
Collaborator Author

Test!

2 similar comments
@nikolayilyin
Copy link
Collaborator Author

Test!

@nikolayilyin
Copy link
Collaborator Author

Test!

@JustinPihony
Copy link
Collaborator

test!

JustinPihony
JustinPihony requested changes Sep 5, 2019
View reviewed changes
Copy link
Collaborator

@JustinPihony JustinPihony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments I'd liked addressed before approving

src/main/scala/beam/sim/CustomTerminateAtFixedIterationNumber.scala Show resolved Hide resolved
src/main/java/beam/matsim/MatsimConfigUpdater.java Outdated Show resolved Hide resolved
src/main/java/beam/matsim/CustomPlansDumpingImpl.java Show resolved Hide resolved
@nikolayilyin
Copy link
Collaborator Author

test!

@nikolayilyin nikolayilyin requested review from JustinPihony and removed request for michaz, REASY and carloscaldas September 5, 2019 21:32
@nikolayilyin
Copy link
Collaborator Author

test!

@nikolayilyin nikolayilyin mentioned this pull request Sep 11, 2019
Closed
@nikolayilyin
Copy link
Collaborator Author

test!

@nikolayilyin
Copy link
Collaborator Author

test!

1 similar comment
@nikolayilyin
Copy link
Collaborator Author

test!

@JustinPihony
Copy link
Collaborator

@irishwithaxe This should be good to go, but will let you do the merging

@wrashid wrashid merged commit 6f29113 into develop Oct 30, 2019
@wrashid wrashid deleted the inm/fix-not-updating-in-real-time-config-values-2 branch October 30, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinPihony JustinPihony JustinPihony approved these changes

@colinsheppard colinsheppard Awaiting requested review from colinsheppard

@wrashid wrashid Awaiting requested review from wrashid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikolayilyin @JustinPihony @wrashid @rajnikantsh