Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Critical Actor trait and use in ZPM #2312

Merged
merged 2 commits into from
Jan 18, 2020
Merged

Add Critical Actor trait and use in ZPM #2312

merged 2 commits into from
Jan 18, 2020

Conversation

JustinPihony
Copy link
Collaborator

@JustinPihony JustinPihony commented Dec 19, 2019 •
edited
Loading

Closes #2311

This change is Reviewable

@JustinPihony
Copy link
Collaborator Author

test!

@robfitzgerald
Copy link
Collaborator

right, it seems there is a set of actors which should never fail in a simulation. should the R5RoutingWorkers, RideHailManager, and BeamAgentScheduler also receive this trait?

@JustinPihony JustinPihony merged commit bdcc66f into develop Jan 18, 2020
@JustinPihony JustinPihony deleted the jp/#2311-critical-exception-trait branch January 18, 2020 19:10
@JustinPihony JustinPihony restored the jp/#2311-critical-exception-trait branch April 23, 2020 04:45
@JustinPihony JustinPihony deleted the jp/#2311-critical-exception-trait branch May 7, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinsheppard colinsheppard colinsheppard approved these changes

@REASY REASY Awaiting requested review from REASY

@robfitzgerald robfitzgerald Awaiting requested review from robfitzgerald

@wrashid wrashid Awaiting requested review from wrashid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a trait which can be used to crash the entire system upon exception
3 participants
@JustinPihony @robfitzgerald @colinsheppard