Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add percentToSimulate to beam-template.conf #2623

Merged
merged 4 commits into from
May 11, 2020

Conversation

crixal
Copy link
Collaborator

@crixal crixal commented May 6, 2020

Closes #2553

This change is Reviewable

@crixal crixal requested review from REASY and wrashid May 6, 2020 15:25
@crixal crixal self-assigned this May 6, 2020
@crixal
Copy link
Collaborator Author

crixal commented May 6, 2020

Test!

@crixal
Copy link
Collaborator Author

crixal commented May 6, 2020

optional annotation is used because default value for list type is not available. I create issue with this problem.

@crixal
Copy link
Collaborator Author

crixal commented May 8, 2020

Test!

@JustinPihony
Copy link
Collaborator

Test!

@JustinPihony JustinPihony merged commit 08467dd into develop May 11, 2020
@JustinPihony JustinPihony deleted the dogurtsov/#2553-percent-to-simulate branch May 11, 2020 05:08
beam-bot pushed a commit that referenced this pull request Jan 11, 2021
* Add percentToSimulate to beam-template.conf

* Revert relaxation type

* fmt

Co-authored-by: Justin Pihony <[email protected]>
REASY pushed a commit that referenced this pull request Feb 4, 2021
* Add percentToSimulate to beam-template.conf

* Revert relaxation type

* fmt

Co-authored-by: Justin Pihony <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Experiment_5_0 parameterized
2 participants