Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed 20 warnings #2651

Merged
merged 7 commits into from
May 20, 2020
Merged

Removed 20 warnings #2651

merged 7 commits into from
May 20, 2020

Conversation

carloscaldas
Copy link
Collaborator

@carloscaldas carloscaldas commented May 14, 2020 •
edited by colinsheppard
Loading

This change is Reviewable

@carloscaldas carloscaldas self-assigned this May 14, 2020
@carloscaldas carloscaldas requested a review from REASY May 14, 2020 01:27
@JustinPihony
Copy link
Collaborator

Test!

@JustinPihony
Copy link
Collaborator

For posterity - my guess is that the file utility is closing a resource prematurely:

RideHailAllocationRandomRepositioningSpec:
23:07:10 - should be able to run for 1 iteration without exceptions *** FAILED *** (1 second, 624 milliseconds)
23:07:10 com.google.inject.CreationException: Unable to create injector, see the following errors:

@carloscaldas
Copy link
Collaborator Author

test!

@carloscaldas
Copy link
Collaborator Author

test!

@carloscaldas
Copy link
Collaborator Author

Test!

@carloscaldas
Copy link
Collaborator Author

test!

1 similar comment
@carloscaldas
Copy link
Collaborator Author

test!

@JustinPihony JustinPihony merged commit 78fa68b into develop May 20, 2020
@JustinPihony JustinPihony deleted the carloscaldas/refactor-2020-05-13-4ci branch May 20, 2020 05:42
beam-bot pushed a commit that referenced this pull request Jan 11, 2021
@carloscaldas
Removed 20 warnings (#2651)
ab2a13b 
* removed 9 warnings - replaced size with length for arrays and strings

* removed 10 warnings - resource not closed

* removed 1 warning - simplified expression

* applied scalaFmt

* removed unused import

* fixed loading in advance all lines

* fixed readAllLines method
REASY pushed a commit that referenced this pull request Feb 4, 2021
@carloscaldas @REASY
Removed 20 warnings (#2651)
80030c5 
* removed 9 warnings - replaced size with length for arrays and strings

* removed 10 warnings - resource not closed

* removed 1 warning - simplified expression

* applied scalaFmt

* removed unused import

* fixed loading in advance all lines

* fixed readAllLines method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinPihony JustinPihony JustinPihony approved these changes

@REASY REASY Awaiting requested review from REASY

Assignees

@carloscaldas carloscaldas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carloscaldas @JustinPihony