write VM heap class histogram at iteration end and/or start #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REASY
requested changes
May 26, 2020
| invoke("gcClassHistogram") | ||
| } | ||
|
|
||
| // commands examples: |
There was a problem hiding this comment.
I'd suggest to use Scala type system to help with possible params. It can be done by using ADT, for example,
sealed trait JFRCommand {
def asStr: String
}
object JFRCommand {
case object GcRun extends JFRCommand {
def asStr: String = "gcRun"
}
}There was a problem hiding this comment.
ok, looks cool, thanks!
| new VMInfoCollector(objectName) | ||
| } catch { | ||
| case _: MalformedObjectNameException => | ||
| throw new RuntimeException( |
There was a problem hiding this comment.
Let's not throw away that exception, but instead, pass it to RuntimeException so there will be more information what went wrong.
|
test! |
REASY
approved these changes
May 31, 2020
|
test! |
|
test! |
2 similar comments
|
test! |
|
test! |
beam-bot
pushed a commit
that referenced
this pull request
Jan 11, 2021
…debug-memory-leaks write VM heap class histogram at iteration end and/or start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is