Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Level Parking Manager #3064

Merged
merged 20 commits into from
Dec 1, 2020
Merged

Link Level Parking Manager #3064

merged 20 commits into from
Dec 1, 2020

Conversation

dimaopen
Copy link
Collaborator

@dimaopen dimaopen commented Oct 26, 2020 •
edited by JustinPihony
Loading

Resolves #3051

This change is Reviewable

@dimaopen dimaopen linked an issue Oct 26, 2020 that may be closed by this pull request
Road side parking #3051
Closed
@dimaopen
Copy link
Collaborator Author

dimaopen commented Nov 3, 2020

Test!

@dimaopen
Copy link
Collaborator Author

dimaopen commented Nov 3, 2020

Test now!

1 similar comment
@dimaopen
Copy link
Collaborator Author

dimaopen commented Nov 3, 2020

Test now!

@dimaopen
Copy link
Collaborator Author

dimaopen commented Nov 3, 2020

Test!

1 similar comment
@dimaopen
Copy link
Collaborator Author

dimaopen commented Nov 4, 2020

Test!

@dimaopen
Copy link
Collaborator Author

dimaopen commented Nov 4, 2020

Test now!

@dimaopen
Copy link
Collaborator Author

dimaopen commented Nov 4, 2020

Test now!

JustinPihony
JustinPihony reviewed Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@JustinPihony JustinPihony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - but it might be worth somebody with more knowledge of the spec on this to also review. I can approve if others feel it is good enough as is though.

@dimaopen
Removed unneeded test from HierarchicalParkingManagerUtilSpec; Added …
b395808 
…the possible options to exception; Configurable checking of correctness of building TAZ level parking info.
@dimaopen
Copy link
Collaborator Author

Test!

@dimaopen
Copy link
Collaborator Author

Test now!

@JustinPihony
Copy link
Collaborator

All looks good after the changes - @REASY or @wrashid do either of you want to look at it from a "does what we expected" or are we ok with my review?

@dimaopen dimaopen merged commit 2abbb1f into develop Dec 1, 2020
@dimaopen dimaopen deleted the do/#3051-link-level-parking branch December 1, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinPihony JustinPihony JustinPihony left review comments

@REASY REASY REASY approved these changes

@wrashid wrashid Awaiting requested review from wrashid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Road side parking
3 participants
@dimaopen @JustinPihony @REASY