Fixes the tick and trigger issue on SingleModeSpec test #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will be adding code to SimRunnerForTest.beforeEach() method, running the CI before after the change so I can analyse if the change had undesirable side effects other than fixing the tick and trigger issue on SingleModeSpec.
|
test! |
|
test! |
|
Turns out, differently from what we thought, there is another test that was throwing this issue: The output after these changes does not contain any instance of the issue: I looked through all the error messages reported on "CI output after change" and, from what I can tell, there is no new kind of error being thrown when compared to "CI output before change". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue happens because the test "let everybody take drive_transit when their plan says so" leaves some electric vehicles plugged into the charging station, then these vehicles are in an unexpected state when the next test "let everybody drive when their plan says so" starts.
Running
beamScenario.privateVehicles.foreach(_._2.resetState())right at the begining of the aforementioned second test fixes the issue. I will be adding this code to SimRunnerForTest.beforeEach() and comparing the CI output before and after the change.This change is