Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging Myungsoo SPM Controller #3693

Merged
merged 49 commits into from
Dec 8, 2022
Merged

Debugging Myungsoo SPM Controller #3693

merged 49 commits into from
Dec 8, 2022

Conversation

haitamlaarabi
Copy link
Collaborator

@haitamlaarabi haitamlaarabi commented Dec 8, 2022 •
edited by colinsheppard
Loading

  • Fixing bugs and issues in site_power_controller_deferate.py
  • Refactoring python code of Site Power Controllers in site_power_controller_utils.py
  • Improving HELICS communication
  • Code refactoring of the SitePowerManager and ChargingNetworkManager

This change is Reviewable

haitamlaarabi and others added 30 commits November 10, 2022 17:10
@haitamlaarabi @nikolayilyin
update
f4a0bdd
@haitamlaarabi @nikolayilyin
update multi-federate to one federate in site power manager
a9e4031
@haitamlaarabi @nikolayilyin
format
f1abc02
@haitamlaarabi @nikolayilyin
adding objects to python
5de20ae
@haitamlaarabi @nikolayilyin
update bis
a9c1073
@haitamlaarabi
generateConfig
79f1583
@haitamlaarabi
fixes to python scripts
2acb170
@haitamlaarabi
adding siting file
1054652
@haitamlaarabi
more fixed
3dea8a5
@haitamlaarabi
update
e030506
@haitamlaarabi
updating SPM
e25962b
@haitamlaarabi
fix python bug
0697973
@nikolayilyin
to test the performance of beam-helics interactions
479050f
@nikolayilyin
to test the performance of beam-helics interactions
1ac022a
@nikolayilyin
Merge branch 'hl/do/site-power-controller-helics-before-develop-merge…
e65abac 
…' of https://github.com/LBNL-UCB-STI/beam into hl/do/site-power-controller-helics-before-develop-merge
@haitamlaarabi
update config
a0060f9
@haitamlaarabi
fix config
c8998a0
@nikolayilyin
Closing helics library only once
7a5389d
@nikolayilyin
not losing messages near the end of the day
792b80e
@nikolayilyin
Merge branch 'hl/do/site-power-controller-helics-before-develop-merge…
6136659 
…' of https://github.com/LBNL-UCB-STI/beam into hl/do/site-power-controller-helics-before-develop-merge
@nikolayilyin
Merge remote-tracking branch 'origin/develop' into hl/do/site-power-c…
ae0018a 
…ontroller-helics-before-develop-merge
@nikolayilyin
arbitrary number of federates with all TAZ used
52d2fd1
@nikolayilyin
fmt
cd763ab
@haitamlaarabi
fix helics
cfd50cb
@haitamlaarabi
merge...
9133f93
@haitamlaarabi
making spmc multithreaded
de744dc
@nikolayilyin
to work with the latest changes in BEAM
b57a5ab
@nikolayilyin
default names
e314bb1
@nikolayilyin
better test
3585f50
@nikolayilyin
Merge branch 'hl/do/site-power-controller-helics-before-develop-merge…
d177f09 
…' of https://github.com/LBNL-UCB-STI/beam into hl/do/site-power-controller-helics-before-develop-merge
nikolayilyin and others added 17 commits November 28, 2022 13:46
nikolayilyin
nikolayilyin approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@nikolayilyin nikolayilyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nikolayilyin
Copy link
Collaborator

test!

@haitamlaarabi haitamlaarabi merged commit d3023d7 into develop Dec 8, 2022
@haitamlaarabi haitamlaarabi deleted the hl/debugging-myungsoo-spmc branch December 8, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolayilyin nikolayilyin nikolayilyin approved these changes

@dimaopen dimaopen Awaiting requested review from dimaopen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haitamlaarabi @nikolayilyin