Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send routing failures to skims #3735

Merged
merged 15 commits into from
Apr 25, 2023
Merged

Send routing failures to skims #3735

merged 15 commits into from
Apr 25, 2023

Conversation

zneedell
Copy link
Collaborator

@zneedell zneedell commented Mar 14, 2023 •
edited
Loading

Several fixes to make sure that the skimmer keeps track of situations where no route is possible from an origin to a destination (particularly relevant for transit) so that we don't keep sending agents on that trip without realizing it's impossible. A couple of changes:

  • Create a new replanning error code RouteNotAvailableForChosenMode for when someone has a mode already chosen but an itinerary of that mode doesn't show up as possible in mode choice. Also added origin (and sometimes destination) location to the replanning event to make it easier understand what happened after the fact. Also create a failedODSkimmerEvent in this situation.
  • Renamed observations in the skims to clarify the difference between a completedTrip and a failedTrip
  • Also create a FailedActivitySimSkimmerEvent so that we record failed trips there too, where this event increases the number of failedTrips that show up in the skims but don't change the averages for the other values at all. Record this value for all possible asim path types for a given trip (e.g. all possible transit modes for a WALK_TRANSIT trip) because if no transit route was returned that means that R5 couldn't find a transit route across all possible transit paths

To do:

  • Add test coverage

@zneedell zneedell mentioned this pull request Mar 14, 2023
Open
4 tasks
@zneedell
Copy link
Collaborator Author

Test!

@zneedell zneedell marked this pull request as ready for review March 14, 2023 21:20
@zneedell zneedell requested a review from dimaopen March 14, 2023 21:20
@zneedell
Copy link
Collaborator Author

Test!

@zneedell
Copy link
Collaborator Author

Test now!

@zneedell
Copy link
Collaborator Author

Test now!

@zneedell
Copy link
Collaborator Author

Test!

@zneedell
Copy link
Collaborator Author

Test!

1 similar comment
@zneedell
Copy link
Collaborator Author

Test!

@zneedell
Merge remote-tracking branch 'origin/develop' into zn/no-route-found-…
5899176 
…replanning-event

# Conflicts:
#	src/main/scala/beam/agentsim/agents/modalbehaviors/ChoosesMode.scala
#	src/test/scala/beam/router/skim/SkimmerSpec.scala
@zneedell
Copy link
Collaborator Author

Test!

@zneedell zneedell merged commit ba88630 into develop Apr 25, 2023
@zneedell zneedell deleted the zn/no-route-found-replanning-event branch April 25, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaopen dimaopen dimaopen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zneedell @dimaopen