-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lawrencium cluster: base functionality #3747
Conversation
nikolayilyin
commented
May 5, 2023
•
edited
Loading
edited
- a beam-environment docker image files - to be able to run any branch with any data without installing any beam dependency
- a shell script to run a job on lawrencium cluster + readme.txt with instruction how to do that
- a small bugfix for our python post-processing script to reduce number of useless output lines in the beamLog
test! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few areas where I see blocking problems. A number are nits or can be argued against.
For the readme (since it is uncommentable)
MEMORY_LIMIT="480" ## in G - should be GB to be more standard and explicit
..
export S3_PUBLISH="false" - should be true?
..
Why some exports have examples, but others empty = all should have something if even "ADD_VALUE_HERE" - minor nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few areas where I see blocking problems. A number are nits or can be argued against.
For the readme (since it is uncommentable)
MEMORY_LIMIT="480" ## in G - should be GB to be more standard and explicit
..
export S3_PUBLISH="false" - should be true?
..
Why some exports have examples, but others empty = all should have something if even "ADD_VALUE_HERE" - minor nit
I left it as |
test! |
test! |
test! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The open comments should still be addressed, but not worth blocking, so approving