Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lawrencium cluster: base functionality #3747

Merged
merged 46 commits into from
Jun 21, 2023
Merged

Lawrencium cluster: base functionality #3747

merged 46 commits into from
Jun 21, 2023

Conversation

nikolayilyin
Copy link
Collaborator

@nikolayilyin nikolayilyin commented May 5, 2023

  • a beam-environment docker image files - to be able to run any branch with any data without installing any beam dependency
  • a shell script to run a job on lawrencium cluster + readme.txt with instruction how to do that
  • a small bugfix for our python post-processing script to reduce number of useless output lines in the beamLog

@nikolayilyin nikolayilyin changed the title initial commit Lawrencium cluster: base functionality May 15, 2023
@nikolayilyin nikolayilyin marked this pull request as ready for review June 2, 2023 12:28
@nikolayilyin
Copy link
Collaborator Author

test!

Copy link
Collaborator

@JustinPihony JustinPihony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few areas where I see blocking problems. A number are nits or can be argued against.

For the readme (since it is uncommentable)

MEMORY_LIMIT="480" ## in G - should be GB to be more standard and explicit
..
export S3_PUBLISH="false" - should be true?
..
Why some exports have examples, but others empty = all should have something if even "ADD_VALUE_HERE" - minor nit

docker/beam-environment/entrypoint.sh Show resolved Hide resolved
docker/beam-environment/entrypoint.sh Outdated Show resolved Hide resolved
docker/beam-environment/Dockerfile Outdated Show resolved Hide resolved
docker/beam-environment/entrypoint.sh Outdated Show resolved Hide resolved
docker/beam-environment/entrypoint.sh Show resolved Hide resolved
lawrencium/src/main/bash/run_job.sh Outdated Show resolved Hide resolved
lawrencium/src/main/bash/run_job.sh Outdated Show resolved Hide resolved
lawrencium/src/main/bash/run_job.sh Outdated Show resolved Hide resolved
lawrencium/src/main/bash/run_job.sh Outdated Show resolved Hide resolved
lawrencium/src/main/bash/run_job.sh Show resolved Hide resolved
Copy link
Collaborator

@JustinPihony JustinPihony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few areas where I see blocking problems. A number are nits or can be argued against.

For the readme (since it is uncommentable)

MEMORY_LIMIT="480" ## in G - should be GB to be more standard and explicit
..
export S3_PUBLISH="false" - should be true?
..
Why some exports have examples, but others empty = all should have something if even "ADD_VALUE_HERE" - minor nit

@nikolayilyin
Copy link
Collaborator Author

export S3_PUBLISH="false" - should be true?

I left it as false because if set to true then two more variables should contain keys, I will mark it in comment

@nikolayilyin
Copy link
Collaborator Author

test!

@nikolayilyin
Copy link
Collaborator Author

test!

@nikolayilyin
Copy link
Collaborator Author

test!

Copy link
Collaborator

@JustinPihony JustinPihony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The open comments should still be addressed, but not worth blocking, so approving

@nikolayilyin nikolayilyin merged commit 4d79a05 into develop Jun 21, 2023
@nikolayilyin nikolayilyin deleted the inm/lawrencium branch June 21, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants