Jupyter: map analysis for osm.pbf and physsim network #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test! |
dimaopen
approved these changes
Jun 27, 2023
|
|
||
| # reading osm file | ||
|
|
||
| osm_map = pyrosm.OSM("../beam_root/test/input/sf-light/r5/sflight_muni.osm.pbf") |
There was a problem hiding this comment.
What if we create an utility method that would check for existence beam_root, and if not found then it would use the project root? That allows not to run jupyter notebooks in a container but directly on the local machine.
There was a problem hiding this comment.
I see no point in that.
In my understanding the script will be used purely for inspiration and as a source for copy-pasting code.
Once the new code is created the paths will be the once required and not the paths from the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.