Fix: ride hail transit re-enable #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix for #3781 |
|
test! |
8 similar comments
|
test! |
|
test! |
|
test! |
|
test! |
|
test! |
|
test! |
|
test! |
|
test! |
|
test! |
1 similar comment
|
test! |
|
test! |
|
test! |
1 similar comment
|
test! |
|
test! |
|
test! |
|
test! |
|
test! |
|
test! |
|
test! |
|
test! |
|
test! |
1 similar comment
|
test! |
dimaopen
approved these changes
Oct 4, 2023
| def logInfo(message: String): Unit = logger.info(message) | ||
|
|
||
| // required for testing purposes | ||
| def logError(message: String): Unit = logger.error(message) |
There was a problem hiding this comment.
Basically we can use it. Though it looks a little strange. What we can do is to create a custom Logback appender (https://www.baeldung.com/custom-logback-appender) and in logback-test.xml add it to the PopulationAdjustment only. Then we can get the appender programmatically and cleanup/check it before/after running a test.
There was a problem hiding this comment.
Previously it did not work with custom appender and logger in the test (the approach was different though), and it looks like suggested change is too much work just to get one test working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is