Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ride Hail transit using pooled legs #3796

Merged
merged 22 commits into from
Oct 26, 2023
Merged

Conversation

nikolayilyin
Copy link
Collaborator

@nikolayilyin nikolayilyin commented Oct 10, 2023

Enabling for RideHail transit trips to utilize RH pooled legs if available

It also includes fixes of issues related to early ride-hail reservation.
It also adds a few jupyter notebooks for analysing beam actor messages and agentsim events.


This change is Reviewable

dimaopen and others added 19 commits September 1, 2023 19:52
…it-pooled

# Conflicts:
#	src/main/scala/beam/agentsim/agents/modalbehaviors/ChoosesMode.scala
…ay lead to "tick in the past" error when we schedule BoardVehicle
@dimaopen dimaopen marked this pull request as ready for review October 24, 2023 13:42
@dimaopen
Copy link
Collaborator

Test!

Copy link
Collaborator Author

@nikolayilyin nikolayilyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few nitpicks

jupyter/agents_events/event_analysis.py Outdated Show resolved Hide resolved
src/test/scala/beam/integration/RHTransitPooledSpec.scala Outdated Show resolved Hide resolved
@dimaopen
Copy link
Collaborator

Test!

@dimaopen dimaopen self-assigned this Oct 26, 2023
@dimaopen dimaopen merged commit b0443e1 into develop Oct 26, 2023
1 check passed
@dimaopen dimaopen deleted the do/ride-hail-transit-pooled branch October 26, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants