Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Graph Explorer preview for wide graphs scrollable #924

Closed
Joeytje50 opened this issue Jan 30, 2023 · 1 comment
Closed

Make the Graph Explorer preview for wide graphs scrollable #924

Joeytje50 opened this issue Jan 30, 2023 · 1 comment
Labels
feature Issues/PRs related to a new feature javascript Issues related to Javascript code

Comments

@Joeytje50
Copy link
Contributor

Some previews, such as Forwast's "103 Waste treatment, Composting of food waste, DK", are way too wide to fit on the screen, so right now it just overflows. Even though those graphs are not that informative, it's still nice to have functionality of the preview function correctly. To fix this, I would think giving the preview a scrollbar to fix the overflow issue would sole this issue.
@Zoophobus Zoophobus added feature Issues/PRs related to a new feature info:usability labels Feb 2, 2023
@Zoophobus Zoophobus added the javascript Issues related to Javascript code label Feb 9, 2023
Joeytje50 added a commit to Joeytje50/activity-browser that referenced this issue Jun 20, 2023
@Joeytje50
Expand the view to include the full width of the graph minimap
e04afa0 
Whenever a minimap is wider than the screen, the minimap will dictate
the width of the graph viewer. This means that the minimap's viewfinder
will also be much wider, and not everything indicated in the minimap's
viewfinder can be shown in your window at the same time.

An alternative solution would be to split up the minimap and the graph
itself, however that would require reworking of a significant part of
the code.

Also, this javascript code could use a cleanup, imho.

refs LCA-ActivityBrowser#924
@Joeytje50 Joeytje50 mentioned this issue Jun 20, 2023
Merged
Zoophobus pushed a commit that referenced this issue Jun 20, 2023
@Joeytje50
Expand the view to include the full width of the graph minimap (#992)
cb656f7 
Fixes scrolling over the full graph:
- issue #924
- Whenever a minimap is wider than the screen, the minimap will dictate the width of the graph viewer. 
- Previously the minimap's viewfinder was also much wider, and not everything indicated in the minimap's viewfinder could be shown in the available window.
@Zoophobus
Copy link
Contributor

Thanks @Joeytje50 for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Issues/PRs related to a new feature javascript Issues related to Javascript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Joeytje50 @Zoophobus