Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logging file timestamp format #1040

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Update logging file timestamp format #1040

merged 1 commit into from
Sep 17, 2023

Conversation

marc-vdm
Copy link
Member

  • Update logging file timestamp format to follow ISO format
  • Safer joining of filepaths with os.path.join
  • Imports following PEP8 + remove unused imports
  • Minor updates to documentation

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog

@marc-vdm marc-vdm added the change PRs related to minor changes to AB label Sep 14, 2023
@marc-vdm marc-vdm added this to the 2.9.1 milestone Sep 14, 2023
@coveralls
Copy link

Coverage Status

coverage: 50.446% (-0.07%) from 50.517% when pulling d8eacb3 on marc-vdm:logger_minor_changes into f48bd62 on LCA-ActivityBrowser:master.

@marc-vdm marc-vdm merged commit a17ad79 into LCA-ActivityBrowser:master Sep 17, 2023
10 checks passed
@marc-vdm marc-vdm deleted the logger_minor_changes branch May 14, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change PRs related to minor changes to AB
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@marc-vdm @coveralls