Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Contribution analysis bugfix #1045

Merged
merged 38 commits into from
Oct 11, 2023

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Sep 22, 2023

This PR is a work in progress and aims to:

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog
  • Link this PR to related issues.

@marc-vdm marc-vdm added bug Issues/PRs related to bugs change PRs related to minor changes to AB labels Sep 22, 2023
@marc-vdm marc-vdm added this to the 2.9.1 milestone Sep 22, 2023
@coveralls
Copy link

Coverage Status

coverage: 50.521% (+0.008%) from 50.513% when pulling 119a5ba on marc-vdm:contribution_analysis into 1715a17 on LCA-ActivityBrowser:master.

@marc-vdm marc-vdm modified the milestones: 2.9.1, 2.9.2 Sep 28, 2023
@marc-vdm marc-vdm changed the title Contribution analysis bugfixes Minor Contribution analysis bugfixes and improvements Sep 28, 2023
@marc-vdm marc-vdm marked this pull request as ready for review October 10, 2023 20:38
@marc-vdm marc-vdm modified the milestones: 2.9.2, 2.9.1 Oct 11, 2023
@marc-vdm marc-vdm changed the title Minor Contribution analysis bugfixes and improvements Minor Contribution analysis bugfix Oct 11, 2023
@marc-vdm marc-vdm merged commit 1ba49e1 into LCA-ActivityBrowser:master Oct 11, 2023
11 checks passed
@marc-vdm marc-vdm removed the change PRs related to minor changes to AB label Oct 21, 2023
@marc-vdm marc-vdm deleted the contribution_analysis branch May 14, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative Contribution Analysis results do not sum to 1
2 participants