Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-Tier contribution analysis tab #1046

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Sep 22, 2023

@mrvisscher This PR is ready for testing by other people, based on more testing I hope we can remove some potential bugs and merge this.

New feature to implement contribution analysis for products.

thumbnail_image

Add:

Example project:
positive_negative_CA.tar.gz

Example:
image

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog
  • Link this PR to related issues.

@marc-vdm marc-vdm added the feature Issues/PRs related to a new feature label Sep 22, 2023
@marc-vdm marc-vdm added this to the 2.10 milestone Sep 22, 2023
@coveralls
Copy link

coveralls commented Sep 22, 2023

Coverage Status

coverage: 53.511% (-0.7%) from 54.184%
when pulling a9ca09f on marc-vdm:first_level_cont
into 05bad41 on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm mentioned this pull request Nov 8, 2023
@marc-vdm marc-vdm changed the base branch from master to v2.10.0 February 9, 2024 14:08
@marc-vdm marc-vdm changed the base branch from v2.10.0 to minor February 20, 2024 12:32
# Conflicts:
#	activity_browser/controllers/database.py
#	activity_browser/layouts/tabs/LCA_results_tabs.py
@marc-vdm marc-vdm changed the title New Product (first-level) contribution analysis tab First-Tier contribution analysis tab Apr 20, 2024
@marc-vdm marc-vdm removed this from the 2.10 milestone Jun 4, 2024
@marc-vdm marc-vdm changed the base branch from minor to main June 28, 2024 10:20
# Conflicts:
#	activity_browser/controllers/database.py
#	activity_browser/layouts/tabs/LCA_results_tabs.py
# Conflicts:
#	activity_browser/layouts/tabs/LCA_results_tabs.py
Add:
- CA data: use actual total instead of sum(abs)
- CA data: make distinction between positive and negative rest values (LCA-ActivityBrowser#886)
- CA data: sort based on average of row instead of first column (LCA-ActivityBrowser#887)
- CA table: consistent dropping of empty (rest) rows (LCA-ActivityBrowser#1044)
- CA figure: add marker to show total score when both positive and negative results present (LCA-ActivityBrowser#647)
@marc-vdm marc-vdm added this to the 2.11.0 milestone Sep 30, 2024
@marc-vdm marc-vdm mentioned this pull request Oct 2, 2024
7 tasks
@marc-vdm marc-vdm added the bug Issues/PRs related to bugs label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment