Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to duplicating to new location #1110

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Nov 7, 2023

Resolves the following bugs:

  1. database of own activity was not always added to checked databases
  2. better handling with multiple locations
  3. replaced exchanges are now deleted from the new process instead of the old one (oops)
  4. context menu option now respects read-only state of the database (is now disabled when database is readonly)

Improves the following:

  • Can now choose RER and/or Europe without Switzerland as alternatives
  • candidates are now found in both source database and dependent database, allowing users to create new supply chains and relink them on the fly.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog

…tabase of own activity was not always added (in case none of the exchanges were in own database) 2) improve handling of multiple locations. 3) replaced exchanges were deleted from the old process instead of the new one.
@marc-vdm marc-vdm added bug Issues/PRs related to bugs change PRs related to minor changes to AB labels Nov 7, 2023
@marc-vdm marc-vdm added this to the 2.9.3 milestone Nov 7, 2023
@coveralls
Copy link

coveralls commented Nov 7, 2023

Coverage Status

coverage: 50.059% (-0.1%) from 50.18%
when pulling 231f26c on marc-vdm:location_linking_bugs
into 015d6e7 on LCA-ActivityBrowser:master.

@marc-vdm marc-vdm merged commit 6cfbebd into LCA-ActivityBrowser:master Nov 8, 2023
9 checks passed
Copy link

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.3), you can get the new version by updating Activity Browser.

🤖beep boop! I'm a bot and this message was an automated action. If updating does not make sense for this issue, just ignore this.

@marc-vdm marc-vdm deleted the location_linking_bugs branch May 14, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs change PRs related to minor changes to AB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants