… tab

… tab

Merge remote-tracking branch 'origin/graph_navigator_simplified' into _fresh_d3v4_MiniMap_working

# Conflicts:
#	activity_browser/app/ui/web/graphnav/navigator.py

…nalysis

…e size to keep it in bounds of the scroll-area

…t it rounds all values to 0.

…d no results.

…l amounts, making the table much more useful. It displays the top 1000 values, much more will slow the calculation down considerably.

…ic size policy isn't doing a good job. Will have to find a working size policy in the future.

…small function that translates the functional unit descritions back to their hashed codes through an existing library, preventing key-errors.

…rong functions.

The functional units ComboBox now functions correctly. I have made a small function that translates the functional unit descritions back to their hashed codes through an existing library, preventing key-errors.

…tton.

…phs.

remove unused legacy code ("_key")
promote contents of get_grid() out of unnecessary method
separate widget definition code from layout within grid

separate widget definition code from layout code
remove from controller.py some code which was left there accidentally in the past

requires moving check function to ActivityDetailsTab populate()

new functions: set_exchange_tables_read_only & set_activity_fields_read_only
the tables currently use .setEnabled rather than .readOnly, as in the activity_fields. This is not so good as it doesn't allow selection (e.g. for copy-paste).
panel.py: remove 'new' from open_new_activity_tab
as it is not necessarily new, and to retain naming convention of signal
add placeholder dict object representing a file which saved in each project containing (amongst other things) the activity keys which are not read-only
activity.py: put erroneously removed '_key' assignments back in, else Signals.activity_modified throws an error after editing fields

… more descriptive

…phs.

…nalysis

…nalysis

…nalysis

# Conflicts:
#	activity_browser/app/ui/widgets/calculation_setup.py

…nalysis

instead of setEnabled (which does not allow selection/scrolling), we use DragDropMode and EditTriggers
rename activity_data to activity_data_grid
rename tables to exchange_tables

…vity-browser into redesign_act_tab

…pdated by user click on database-read_only checkbox

rename function to update_activity_table_context
improve and reduce some comments
in update_activity_table_context: check that the open activity inventory table is the one that read-only is changed for (to prevent minor bug with context menu enabled/disabled)
rename ActivityTab argument 'activity' to activity_key, which consists of the BW tuple (db_name, code [or act_code]) according to:
https://docs.brightwaylca.org/intro.html#activities-must-be-uniquely-identified
remove need for extra call of new_tab.populate() in open_activity_tab by passing the activity_key sooner

currently saving state to files is just simulated with static dictionary objects
next: implement saving to new settings files (to be created) in the BW projects directory

on startup and each time a new project is selected, user_project_settings reads the settings from disc (in the bw2 project directory) or creates a new file there.
Contents of settings file not yet being properly parsed or saved

now parsed and saved at necessary times
used to drive valid read-only behaviour

aligned with existing function naming conventions

This enables the appropriate stylesheets to work
add to file style.py the class ActivitiesTab
update the active stylesheet when the read-only status of an activity changes
currently adds a green or red border to indicate status
update utils to give a longer tab title (30 instead of 22 chars)

increase size of read_only checkbox

not editable or writable

	automatically opens new activity when copied
	read-only databases are no longer accessible on the list selection

still todo: refactor controller.py duplicate_activity_to_db method

Update the widget name label, tooltips,
and check behaviour (using NOT inversion on parameter pass)
have not changed the use of 'read-only' throughout the rest of the codebase

remove database from project settings file when deleted
reset settings object when project is deleted
change value formatting from scientific {0:.3e} back to mixed notation {:.3g}
remove border of detailsgroupboxes to reduce interface clutter
...todo: auto-size column widths within exchangetables on init or update. Nothing so far seems to affect them

... by running command 'optimize imports' from PyCharms on open edited files

…-browser into Results_Analysis

… of editable databases

modify function name to update_activity_table_read_only for more general context

…se after user edits

…ser into redesign_act_tab

… radio buttons

…tons

…are now named properly and have switched places with the combobox where the functional unit or LCIA Method can be selected.

…a horizontal layout, inline with one another.

… preference of bsteubing

…s can't be copied to read-only dbs

rename activity tab functions to db_read_only_changed and act_read_only_changed for clarity and consistency

allows user to select from all location names which already exist in the database of the selected activity
Or add a new location that's not in the list, simply by typing

whilst implementing - found an issue that was causing many issues in the past and in this function implementation...
The "activity" data was redundantly duplicated in objects across the interface:
	addressed in this commit: ActivityTab.activity and ActivityDataGrid.activity redundancy
	not addressed in this commit: the *possible* redundancy between the ActivityCache and ActivitiesPanel, which is less clear-cut

ActivityDataGrid.activity is no longer stored. Rather, the ActivityTab is referenced as a parent, and the ActivityTab.activity object used in all code
Such that when data is being edited, it is no longer necessary to maintain synchronisation of these two separate objects, as well as the displayed values in the widgets

Also addressed the assumption(?) in previous code, that an ActivityTab instance could be created without an activity_key. This might have been a legacy thing.
	No longer provides default values for activities
	Or checks if an activity was passed (e.g. before populate()

rename all references to 'dropdown' to 'combo' - aligned with PyQT naming convention

…ui/tabs/activity.py and related calling functions

to develop my understanding, and in preparation for an open discussion on optimal design/behaviour for these tables
next: reverting mostly back to previous table-column layout (names etc.), from before I made any changes
...to screenshot images and act as a uncontroversial/familiar starting point, for development discussion

…ry table to show data for all functional units simultaneously

…multaneously and changed labels to be more complete.

…le to Excel has been tested and works for the full table now.

revert some ExchangeTable column/design changes
...I previously misunderstood which specific types of data should be shown in each column, and hence removed too many
Add in-line documentation, comments, and TODO suggestions for further improvements
rename filter_clicks to filter_double_clicks
modify the way that the exchange tables are set to read only/editable so dragging still permitted as in earlier versions
	- from setDragDropMode(DropOnly) to self.setAcceptDrops(True)

... tried to resolve conflict in the GitHub editor which meant that a conflict-tag (<<<<<<< redesign_act_tab) could slip through

Pulling Tom's work into the changes_LU branch to integrate all the recent work of LU