Tooltips in LCA Results #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to LCA Results, EF Contributions and Process Contributions tab
|
Looks good! One thing I'd like to ask you to do is to change the descriptions from 'LCIA method' to 'Impact Category' (following #325). |
|
Nice, I'll squash and merge after the tests go through. Thanks for adding the tooltips! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tooltips to three sub-tabs in the LCA Results tab.
LCA Results: tooltips for the 'overview' and 'by LCIA method' buttons.
EF Contributions and Process contributions: tooltips for all options in cut-off menu and 'relative' and 'absolute' buttons.
The 'relative'/'absolute' buttons were moved left to give a more consistent view IMO.
Plot/Table, export buttons and the 'compare FU/IC' options were deemed clear enough.