Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly delete and replace self.plot when update_plot is called #363

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

dgdekoning
Copy link
Contributor

@dgdekoning dgdekoning commented Jan 30, 2020

Fixes #286, possibly.

By replacing the self.plot object in-place in the layout, plotting changed values and finally calling updateGeometry on the widget that owns the layout it should avoid the redraw (and scaling?) issue for macOS devices.

@coveralls
Copy link

coveralls commented Jan 30, 2020

Coverage Status

Coverage decreased (-0.3%) to 51.342% when pulling aaf5e3c on force-plot-replace-mac into 2dff150 on master.

@dgdekoning
Copy link
Contributor Author

@nheeren, @cmutel, can either of you test this branch to see if it resolves the issue?

On windows it seems no functionality is lost, but I'm unsure if replacing plots in-place actually resolves the scaling issue.

@cmutel
Copy link
Contributor

cmutel commented Feb 4, 2020

It is better (there is no shrinkage), but there are sometimes still artifacts from previous plots:
Screenshot 2020-02-04 at 15 55 33
Maybe just need to clear the figure first?

@dgdekoning
Copy link
Contributor Author

Weeeeeird, I'll add a 'clear plot' call before the deleteLater call.

@dgdekoning dgdekoning merged commit 51ba701 into master Feb 18, 2020
@Zoophobus Zoophobus deleted the force-plot-replace-mac branch December 4, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HiDPI / Retina screens cause redraw issues leading to a singular matrix error
3 participants