Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reindex to fill empty column with NaN values #386

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Use reindex to fill empty column with NaN values #386

merged 2 commits into from
Apr 7, 2020

Conversation

dgdekoning
Copy link
Contributor

Fixes #385.

@coveralls
Copy link

coveralls commented Mar 9, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 58.613% when pulling 9febd24 on dgdekoning:fix-385 into 8a0285b on LCA-ActivityBrowser:master.

@dgdekoning
Copy link
Contributor Author

Second commit will ensure that the legend and plot labels for all contribution plots will be correctly shown.

This does mean the labels no longer completely match the functional unit names from the table but I found the immediate clarity of which functional unit matching which color in the graph to be more important.

@dgdekoning dgdekoning merged commit 05771d2 into LCA-ActivityBrowser:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calculation setups using forwast activities fail
2 participants
@dgdekoning @coveralls