Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split controller into separate controllers #492

Merged
merged 5 commits into from
Jan 22, 2021
Merged

Split controller into separate controllers #492

merged 5 commits into from
Jan 22, 2021

Conversation

dgdekoning
Copy link
Contributor

By separating the controller into separate parts we improve the readability of the methods, and related logic.

Additionally, subclassing the controllers from QObject means we can hook them into the the QMainWindow object and inject this into any additional dialogs spawned by the controllers.

@dgdekoning dgdekoning added the feature Issues/PRs related to a new feature label Jan 7, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 54.11% when pulling 2658bcb on dgdekoning:split-controller into 4162ef1 on LCA-ActivityBrowser:master.

@dgdekoning dgdekoning merged commit 0a00f45 into LCA-ActivityBrowser:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Issues/PRs related to a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgdekoning @coveralls