Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests for python 3.10 #726

Closed
wants to merge 2 commits into from

Conversation

haasad
Copy link
Member

@haasad haasad commented Feb 18, 2022

No description provided.

@haasad haasad marked this pull request as draft February 18, 2022 15:48
@coveralls
Copy link

coveralls commented Feb 18, 2022

Coverage Status

Coverage remained the same at 54.445% when pulling b6a3d4f on haasad:test-py310 into 0d4a531 on LCA-ActivityBrowser:master.

@marc-vdm
Copy link
Member

@haasad, the logs of the tests have been deleted so I can't check this (or re-run the tests?).
Do you recall the reason why AB didn't work with 3.10 and what we should do to fix it?

@haasad
Copy link
Member Author

haasad commented Sep 22, 2023

I've added a commit to trigger the pipeline again. IIRC there were some segfaults on linux. I'm on holidays currently, won't be at a computer until next week

@marc-vdm
Copy link
Member

marc-vdm commented Sep 22, 2023

Thanks! Enjoy your holidays!

edit:
I suggest we review this again somewhere in end October/start November as 3.12 is scheduled to release early October. Then we can see if we can just transfer to 3.11 and 3.12 and skip 3.10 as it does seem to be still broken.

@marc-vdm
Copy link
Member

Note, when moving to newer version, we should update the pint fix (#982)

@marc-vdm
Copy link
Member

@haasad can I close this and #1124 or would you still like to try and figure out what the issue was?

@haasad
Copy link
Member Author

haasad commented Dec 20, 2023

Fine to close, can always reopen if needed

@haasad haasad closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants