-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the base exception from the requests library #396
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
62808f0
Handle the base exception from the requests library
mgdaily 8078119
Update image tag in prod values
mgdaily 710258b
Do not retrieve related frames from archive API response
mgdaily 1942cbc
Update e2e tests to use in-cluster URLs, too
mgdaily ea709e9
Revert "Update e2e tests to use in-cluster URLs, too"
mgdaily File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,20 +6,20 @@ | |
# will be started when the CPU usage rises above the configured threshold. | ||
horizontalPodAutoscaler: | ||
enabled: true | ||
minReplicas: 15 | ||
maxReplicas: 15 | ||
minReplicas: 25 | ||
maxReplicas: 25 | ||
targetCPUUtilizationPercentage: 50 | ||
minLargeReplicas: 7 | ||
maxLargeReplicas: 7 | ||
minLargeReplicas: 12 | ||
maxLargeReplicas: 12 | ||
|
||
image: | ||
repository: ghcr.io/lcogt/banzai | ||
tag: "1.18.1" | ||
tag: "1.18.2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this match the version number above in the changes? That's currently 1.18.3... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch. |
||
pullPolicy: IfNotPresent | ||
|
||
# Values for the OCS Ingester library, used by BANZAI. | ||
ingester: | ||
apiRoot: http://archiveapi-internal.prod/ | ||
apiRoot: http://archiveapi-internal/ | ||
s3Bucket: archive-lco-global | ||
ingesterProcessName: banzai_imaging | ||
opentsdbHostname: opentsdb.lco.gtn | ||
|
@@ -30,19 +30,19 @@ ingester: | |
|
||
# Values specific to the BANZAI pipeline | ||
banzai: | ||
astrometryServiceUrl: http://astrometry.lco.gtn/catalog | ||
configdbUrl: http://configdb.lco.gtn/sites/ | ||
observationPortalUrl: http://internal-observation-portal.lco.gtn/api/observations/ | ||
astrometryServiceUrl: http://gaia-astrometry-net-service/catalog | ||
configdbUrl: http://configdb3/sites/ | ||
observationPortalUrl: http://internal-observation-portal/api/observations/ | ||
useDifferentArchiveSources: false | ||
calibrateProposalId: calibrate | ||
banzaiWorkerLogLevel: info | ||
rawDataApiRoot: http://archiveapi-internal.prod/ | ||
rawDataApiRoot: http://archiveapi-internal/ | ||
fitsBroker: "amqp://science-archive:[email protected]:5672/science-archive" | ||
fitsExchange: archived_fits | ||
queueName: banzai_pipeline | ||
celeryTaskQueueName: banzai_imaging | ||
largeCeleryTaskQueueName: banzai_large_imaging | ||
PhotometryCatalogURL: http://phot-catalog.lco.gtn/ | ||
PhotometryCatalogURL: http://photometric-catalog-service/ | ||
openSearchURL: https://opensearch.lco.global/ | ||
|
||
# CronJob configuration to periodically update instrument table in BANZAI DB | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably talk about how to introduce autoscaling someday when you have the bandwidth...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to set a max replicas here? Or just assume if we only set a min, they are equal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jashan did prototype this at one time. https://github.com/LCOGT/banzai/pull/359/files
Autoscaling based on queue size sounds great Joey, but I am very hesitant to commit my time to this as a development priority. I think it is relatively high effort to low gain, given that we can simply run more pods than we need most of the time.
I would love if someone other than me could spearhead that effort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we need to. https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.31/#horizontalpodautoscalerspec-v2-autoscaling
This has always been the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Ok. github split the file and I missed the next line.