Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/recursively get components #60

Merged
merged 8 commits into from
Aug 16, 2021

Conversation

sanjayankur31
Copy link
Contributor

This improves the exposure path listing functionality to list all paths that can be obtained from the declared model. it traverses the component tree starting at the target node to get all children/instantiations.

Things to check:

  • scope of methods: maybe not all methods here need to be public
  • method names: better names for public functions?

Previously, when we used `self.components,` we only got the top level
components because that's what `self.components` holds.

Now, we use `self.components` as a starting point and recursively find all
child/children components also.
We can now list paths for all exposures that can be obtained from the
model declaration. We do not build a simulation of the model, so
exposures, connections, and other elements (and so their exposures) that
are created at build time are not included.
Add assertions to check for paths for multi-instantiated Population
component.
@sanjayankur31 sanjayankur31 self-assigned this Aug 16, 2021
sanjayankur31 added a commit to NeuroML/pyNeuroML that referenced this pull request Aug 16, 2021
This ensures that later list modifications do not affect stored
information.
@pgleeson pgleeson merged commit ae8655c into development Aug 16, 2021
@pgleeson pgleeson deleted the feat/recursively-get-components branch August 20, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants