This repository has been archived by the owner on Mar 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
demonstrate syncing with block_position
indexing
#119
Open
rajarshimaitra
wants to merge
4
commits into
LLFourn:master
Choose a base branch
from
rajarshimaitra:block-position
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajarshimaitra
changed the title
Block position
demosntrate syncing with Jan 4, 2023
block_position
indexing
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 65.30% 61.14% -4.16%
==========================================
Files 8 8
Lines 294 314 +20
==========================================
Hits 192 192
- Misses 102 122 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rajarshimaitra
force-pushed
the
block-position
branch
from
January 4, 2023 19:22
ceeb33c
to
b76511c
Compare
LLFourn
reviewed
Jan 5, 2023
rajarshimaitra
force-pushed
the
block-position
branch
from
January 6, 2023 06:10
52a89e6
to
666ef9a
Compare
Can you try and re-do this PR on top of master @rajarshimaitra? |
rajarshimaitra
force-pushed
the
block-position
branch
from
January 10, 2023 06:11
666ef9a
to
3cf3831
Compare
@LLFourn rebased on master.. |
LLFourn
reviewed
Jan 11, 2023
evanlinjin
changed the title
demosntrate syncing with
demonstrate syncing with Jan 12, 2023
block_position
indexingblock_position
indexing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attemted approach at #85 . Not final and can be structured better. Opening up for approach discussions.
Build on top of #77 and demos it over electrum API.
Things Done:
BlockPosition
struct that isChainPosition
with custom ordering.TxHeight
tracker and db won't be updated in that call.Question: