This repository has been archived by the owner on Mar 14, 2023. It is now read-only.
Electrum sync 2 #81
Closed
Electrum sync 2 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ChainGraph` structure now ensures there are no "floating txids". All txids mentioned in the internal chain must exist in the internal graph.
This is an electrum example on top of PR LLFourn#80. To facilitate discussions around the ongoing Chaingraph invariant work.
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 50.83% 50.83%
=======================================
Files 9 9
Lines 602 602
=======================================
Hits 306 306
Misses 296 296
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Closing this in favor of #77 .. This dumb way of syncing doesn't make sense when we can do step by step syncing using sparsechain. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate version of the electrum syncing example on top of #80 .. The update chain graph now contains all the wallet related transaction data, both new and old.. And sync isn't performed in two steps because of the invariant, and the result I think is very similar to esplora syncing..